Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
If Gordon Ramsay made code reviews, I would watch that show. Especially the insults he would use for handling clients.
"This code has so much spaghetti, it decided to open it's own restaurant"23 -
In case anyone was wondering if Apple ever actually tests updates during review, they do. Sometimes, apparently, they also use devRant with the provided test account. Hopefully their rant/comment quality improves, but they are trying!!
10 -
Peer review is a life saver!!! My colleague just saved me my job as i almost published this fucking block to production.
18 -
*Working on app for client*
After review - “Can you make that font bigger?”
*Makes font larger*
After review a week later - “Can you make that font smaller?”
*Puts font back to original size*
Another review later on - “Can you make that font bigger?”
*Keeps font at same size and changes nothing*
Next review - “That new font size is perfect!”1 -
I sometimes wonder my English is that bad ...
I reviewed a pull request. I commented on this line of code
a = getA() * -1;
saying that
"I think this logic should be in setA method instead."
When the guy asked me for the review again, the change was
- a = getA() * -1;
+ a = setA() * -1;
...2 -
*Doing a Peer Code Review of someone senior to me*
Me: This fix doesn't look like it will work, but maybe I don't understand. How does this fix the defect?
Senior Dev: *Blinks* It works on my machine
Me: But how does it work?
Senior Dev: It works when I run it on my machine...
Me: Do you know if this will fix the issue?
*Silence*
Never seen QA punt an issue back to development so fast.7 -
Annual performance peer review
Person who did review me wrote in the section “skills needed to improve”:
“He is introverted...”
Bloody hell!! What a big problem :) and how in earth you can “fix” it? And why everyone expected to be extraverted??10 -
Code Review:
Me: this is wrong, it doesnt work when XY
Dev: yes but it will work in 99 of 100 Times, i won't change it15 -
fujioaskl;f;asdfjkl
WHY THE FUCK DOES MY BOSS HAVE ME MOCKING FUCKING RECAPTCHA API RESPONSES? IT'S SO FUCKING STUPID
I CAN'T MOCK THE RECAPTCHA JS METHODS SO I HAVE TO MAKE VALID-LOOKING JSON RESPONSES AND I DON'T HAVE A FUCKING CLUE HOW ANY OF IT FUCKING WORKS
THIS IS THE STUPIDEST THING ANYONE HAS EVER ASKED OF ME (okay, it isn't, but it's pretty damned close.) AND IT'S DURING MY BLOODY PERFORMANCE REVIEW.39 -
Not sure what triggers me more:
a) the fact that nowadays no one can type/spell without auto-correct
b) that this passed code review
c) that no one corrected it in 12 months since it's been committed
23 -
FUCK GOOGLE.
FUCK THE GOOGLE PLAY REVIEW TEAM.
FUCK THEIR BOT GENERATED EMAILS.
FUCK THEIR DEVELOPER SUPPORT.
I am trying to launch a fucking action game. There will be fucking guns and muzzle flashes shown in the screenshots. Stop fucking rejecting the app. There is no blood in the icon or screenshots. Stop sending me bot generated emails and tell me what content is being flagged.
A little information on the whole scenario: My game was rejected so immediately I contacted the support as to what was the issue. The guy told me 2 screenshots were flagged because they had the muzzle flashes and damage indicator (call of duty type which tells the direction from where the bullets are coming from). So I removed the screenshots and still the game was rejected. FUCK THESE ASSHOLES. SAME GOES FOR APPLE.9 -
I just love going through the code review gauntlet doing maintenance work, don’t you?
(“boyscout rule” = “leave it better than you found it”)
7 -
Created a function called upDawg and started sprinkling it all over the code base. Waiting to see who catches it in our next code review.
All it does is console logs 'Not much man, you?' -
A week in code:
Mon: Write all the code💻
Tue: Review all the code🔍
Wen: Fix all the broken code🔴
Thurs: Deploy🚢
Fri: Review all the code🔬4 -
Uploaded an app to Appstore and it was rejected because the Gender dropdown at registration only has "Male" and "Female" as required selectable options. The reviewer thought it was right to force an inclusion of "Other" option inside a Medical Service app that is targeting a single country which also only recognizes only Male/Female as gender.
Annoyingly, I wrote back a dispute on the review:
Hello,
I have read your inclusion request and you really shouldn't be doing this. Our app is a Medical Service app and the Gender option can only be either Male or Female based on platform design, app functionality and data accuracy. We are also targeting *country_name* that recognizes only Male/Female gender. Please reconsider this review.
{{No reply after a week}}
-- Proceeds to include the option for "Other"
-- App got approved.
-- Behind the scene if you select the "other" option you are automatically tagged female.
Fuck yeah!44 -
I give up. It‘s impossible to argue with Apple.
I tried to bring my unofficial iOS devRant app "JoyRant" into the AppStore. It was available via TestFlight for years and it wasn‘t a problem there, apparently. Now for the AppStore, it is a problem.
I talked with the Apple review team for 3 weeks and the discussion went in circles.
They said that my app tries to disguise as or to misrepresent another app on the store (the official devRant app, even though it‘s not available anymore, apparently).
I was asked to remove all of the mentions of devRant from any description or any place in the app. I did. Even though it was stupid because how are people supposed to know that they need a devRant account to use my app? I‘m not allowed to mention devRant.
After that, they said that it can not have the name JoyRant because it sounds too similar to devRant.
I changed it to devJoy everywhere, the app, the meta data for the app store, the github page where the required legal crap is hosted, and in the legal documents themselves.
Did it help? No, it didn‘t.
Apple then proceeded to claim that my app is trying to deceive the users into thinking that this is the official devRant app. Even though I have explicitly stated in the description that it is just an unofficial devRant client.
Now apple says that I should "revise the app content".
Which I assume means that I need to make it something different. Yeah. Great suggestion!
So, I will rename the app back to JoyRant and provide it via TestFlight, as it was before.
Thanks for reading. I needed to vent.31 -
{Context: English is not my native language}
The first time my code get a review ( by my boss that time)
Boss: Your code is full of butts 🍑
Me: Eh, What?
Boss: *showing his screen* see that? variables names: validateButt, contactButt, seeMoreButt..
Me: *interrupting him* oh, I mean button.
Boss: I know, just being sarcastic, but it'll be better to get another suffix.
Me: 😐11 -
Project Cortana: Day 1
I have seen a lot of people switching to Linux or other services to get away from all the data collections. It makes a lot of sense as no one would want their data to be sold without their consent.
But I am going to do something different. My aim is to integrate with Microsoft apps as much as possible and review the experience. So here is what I have done so far:
* Use Cortana in desktop and mobile (Android)
* Use Microsoft launcher in mobile
* Outlook as primary email provider (I was already using them as my default provider)
* Use Microsoft To-Do and calendar to keep track of things
* Use OneDrive to store all my files (I am moving them from Google Drive)
* Use the default Mail app on the Windows 10
* Use Onenote (I was using Evernote before)
* Use Edge on desktop and Mobile
* Use Skype instead of Hangouts
It's day one but I think I have already found it quite useful. For example:
* Adding reminder is much easier. I get them on both desktop and mobile which is nice.
* Mail app has been really useful. Especially the focused inbox really helps to get rid of the clutters. Also, I can immediately add a mail to the calendar (like Inbox by Google) which is really helpful.
* One of the features of edge that I have found really useful is that you can send web pages from mobile to desktop in one tap. That is extremely useful.
So far I am loving it.
Also, I tried to make sure that I am not sharing my data with third-party apps as I have turned off "relevant ads" feature.43 -
(Forgot to post this a few days ago. Was just too tired.)
Finally finished the code review from hell.
The patch on top of the PR is +1448 -1114, and nearly all of it is rearchitecting, not moving.
I think I spent six days on it, 4-5 productive hours a day? Seems like a lot. This codebase is a bitch to work in.
I’m spent.1 -
A badass pull request review comment: 'A wise man can learn more from a foolish question than a fool can learn from a wise answer.'2
-
$work is migrating to a new HR performance review service (15five). Instead of a private (ish) review once a quarter, it'll be public (and uneditable) reviews due every friday. Better make sure that review is perfect.
also, praising a coworker is required.
<sarcastic thumbs-up>13 -
My company is asking me to create a new gmail account everyday and write a positive review with 5 stars for their iOS app on App Store. Is that even legal? Should I say no? I’m a fucking engineer, not a click-farm worker.10
-
Le me: "my code is awesome! The way I did XY and Z is insanely cool, efficient, and maintainable."
Le Boss: "yeah so let's schedule a code review next week."
Le me : "... fuck, Fuck, FUUUUCK!"
Internal Screaming3 -
Fuck Apple and its review system
So, this started in december. We wanted to publsih an app, after years of development.
Submit to review, and passes on the first try. Well, what do you know. We are on manual release option, so we can release together with the android counterpart. Well yes, but someone notices that the app name is not what was aggreed (App Name instead of AppName). Okay, should be easy, submit the same app, just the name changed. If it passed once, it will pass again, right? HAH
Rejected, because the description, why we use the device’s camera is too general. Well... its the purpose of the app... but whatever, i read the guidelines, okay, its actually documented with exapmles. BUT THEN WHY THE FUCK COULDNT YOU SAY THAT ON THE FIRST UPLOAD?
Whatever, fix it, new version, accepted, ready to release just in time.
It doesindeed roll out,but of course, we notice that the app has a giant issue, but only on specific phones. None of our test phones had this problem, but those who have, essentially cannot use our program. Nasty as it is, the fix is really easy, done in 5 minutes. Upload it asap, literally nothing changed from user point of view, except now it doesnt crash on said devices. Meanwhile 1 star reviews are arriving from these users - of course with all the right. Apple should allow this patch quickly, right? HAH
THE REAL BULLSHIT COMES NOW
With only config files changed, the same binary uploaded we get rejected? What now? Lets read it. “Metadata rejected, no need to upload new binary”.... oh fine only the store page is wrong? Easy. Read the message, what went wrong. “Referencing third party content is nit permitted on the app store” meaning that no android test device should be shown. Fine, your rules. They even send a picutre of the offending element. BUT ITS NOT EVEN ON THE STORE. THATS A SCREENSHOT OF THE APP. HOW IS THAT METADATA? I ask about this, and i get a reply, from either a bot, or a person who cant speak or read english, and only pasted a sample answer, repeating the previous message. WTF. Fine, i guess you are dumb, but since they stop replying to our queries, do the only sensible thing, re-record the offending tutorial video that actually contained an android device. This is about 2 weeks, after the first try to apply a simple patch to a broken app. And still, how did it pass the review 2 times?
Whatever, reupload again, play the waiting game for a week, when the promised average wait time is 2 days, they hit us with a message, that they want to know what patent we use in our apps core functionality. WTF WHY NOW? It didnt bother you for a month, let it release ti production and now you delay a simple patch for this? We send them what they know. Aaaaand they reply: sorry we need more time to review your app. FUUUUUUCKKK YOUUU. You are reviewing a PATCH with close to zero functional change!!! Then, this shit goes on, every week we ask about an ETA, always asking for patience... at the end it took another 3 weeks... so december 15 to jan 21 in total...
FOR. A. SINGLE. FUCKING. PATCH
Bottom line is what is infurating, apple cares that there is an android device in the tutorial video, but they dont care that a significant percentage of our users simply cannot use the app.
Im done7 -
In image: "Downloading now, if it's good, I give it 2 more stars." And never came back.
Here in Brazil, it's not hard to find this kind of review in almost every single app, unfortunately.
6 -
I'm sorry, but the Apple App Store review team sometimes doesn't have the slightest clue what they're doing. Some things they usually reject me for, I can literally name 100 apps that violate that same thing, that are ON the App Store.
But the one that always gets me the most, is they will reject your app for not having extremely strict blocking/reporting features in your app (if it involves user-generated content). Okay, I get this, so I implement it. But they reject my app without even looking for them.
It's a CHAT app, so I put the block button INSIDE the chat conversation (right? normal UX? am I crazy?), and they reject it because they couldn't find the block button on the first screen (a screen that didn't even have chats, they screenshotted the SIGN UP screen LOL).
What a joke. Normally I wouldn't care but this update that I'm trying to get approved is essential and fixes some important crashes that have been happening to 13% of active users.3 -
My first performance review as a graduate:
Boss: "we can't give you the rating you deserve because HR"
Me: "ok whatever, what can I do to get the rating I'm suppose to get?"
B: *lists job description of a senior developer* ... "Interview candidates, mentor juniors, start a project and make me profit"
Me: (if I can do that as a graduate, what am I doing here?)
My last performance review at the same company:
B: "we can't give you the rating you deserve because HR"
M: "ok what can I do to improve?"
B: *lists everything I did before the first performance review that wasn't expected of me*
M: (LoL funny, I just wanted to hear your response because I know you'd forget about the first review. Another reason to validate my resignation) -
I was asked by a client to code review their platform built in PHP. The platform was becoming slow and new features built by their current IT supplier broke existing features.
I gained access to the source code... One PHP file (index.php) containing about 80K lines of code... I am impressed and disgusted at the same time. 😂3 -
I recently received a 1 star review in the App Store. I have answered him twice to ask about which issues he had and what features were missing to him.
He responded really aggressively by posting this:
I purchased this app for my Sonos and found it very simple for an app I had to pay for. I gave it a 1 star and wrote why. Since then the designer has contacted me twice complaining about my review. Sorry, but I am entitled to my opinion and I want you to stop harrassing me because I think your app is basic and doesn't always work right.
DO NOT WRITE ME AGAIN. Suck it up and let me have my own opinion for what I paid for. If you don't like it, make the app free in exchange for 5 ego stars.7 -
001 REM Code review
010 PRINT "Nitpick nitpick nitpick nitpick nitpick"
011 GOSUB REFACTOR
020 PRINT "This function is too complicated, break it up"
021 GOSUB REFACTOR
030 PRINT "Why do you have three methods for this? Put all the logic in one method."
031 GOSUB REFACTOR
040 GOTO 020
041 REM ARGH
998 PRINT "Looks good."
999 STOP8 -
No Microsoft Word, I'm pretty fucking sure it's spelled Git and not Gilt.
#Preparing Code Review Docs5 -
I recently left a job after a few years of intense work and long hours. After leaving, I left a critical but fair Glassdoor review. Since then, I have received multiple emails from the CEO of my former employer asking me to remove the review and including (what I perceive to be) threats of the industry being “small” and mentioning my new manager by name.
I had seldom spoken to the CEO before these emails – a bit of small talk here and there in the office – and his notes to me contained details about personal and family struggles (as justification for poor leadership and mistreating employees?) that I thought verged on inappropriate. I had also delivered all of the feedback in my review throughout my tenure at the company – and, of course, had not received any interest from leadership in discussing my thoughts until I made them public.
What is the best way to respond here? As an attempt to diffuse the situation, I sent a kind email back acknowledging that working there was at times difficult, but also expressing my gratitude for all I learned and the opportunities I had. After that email, he again asked that I remove the review and made reference to the “small community” of the industry.
Should I remove the review? Is he really going to tell my new boss that I left a critical (but truthful) Glassdoor review? If he does, will my new boss even care, or will he see this as a weird and inappropriate overstep from my old employer?12 -
New developers(5-6 years experience) these days are so pathetic. They dont have any sense of code review. All they want is to put their opinion out without giving any thought.
I had a PR for review today which contains mock specification to match a regular expression and return the corresponding response
The regular expression I put was
104000(02|06|20|48)
Now, this guy comes and puts a comment that we could "simplify" as 104000\d{2}
I replied, the ending digits are not contiguous. The specific pair of digits have to match for these mocks.
Then this guy replied, then we could simplify as 104(0{4}(2|6)l0{3}(20|48)).
I said, I cannot understand how that is simplification. Why do we need such a complex regex to match something very straight forward.
And the guy replied, we should be writing proper regexes, otherwise we could just specify everything explicitly.
I was like WTF man. You try deciphering this next week without taking at least a minute to know which values are matched.
Anyhow, another senior person approved my PR, and I merged it.12 -
Me: Are you sure you want this in the acceptance test procedure?
Lead: Yes.
Me: I'm just saying, we don't have any requirements for this feature so it doesn't really belong there.
Lead: Just put it in.
Me: Are you sure? It's a lot of work for something that isn't even required to be there.
Lead: Go do it.
Me: Okay.
*I do the work and it goes to peer review*
High ranking person from another team: I don't see any requirements traceability. Why is this in here if there are no requirements?
Me: WELL AIN'T THAT A GOOD GODDAMN QUESTION!?3 -
Dear people who leave bad reviews...
Do not use a review as a bug report, saying something crashes on your device and telling the developer to "fix this" isn't a review.
It is barely a bug report but a review is on quality, not individual issues .-.3 -
When a senior developer changes your impeccable code and pushes their ugly indented lines with bad naming scheme without review.
-
All I've been doing at work last few days is code review. Damn, I feel bored. Just give me something to code already!3
-
So, my boss is pretty cool. Two of my colleagues made a review of my code (me being new, also on job training). We three were sitting in front of my code, me explaining enthusiastically my code, one of my colleagues looked a bit confused. My boss listening to the whole conversation, he said: "Her code works perfectly". But the way he said it, priceless! I swear, he had a very 'bitchy' voice and also waved while saying that. He looked proud, and we started to laugh.4
-
Going for my first code review. My colleagues and I will read through my main class, which is 832 lines long and a two-three comments.
3 -
First code review ever, and it's for my job.
Guy was really nice and polite.
Even correctly guessed I don't have much experience with professional coding outside my associates degree and prior job where I was the only programmer most of the time I was there.
Said that since it works functionally and is such a small program there's nothing wrong with it if it meets our purposes ( low priority project )
Then he politely in his words 'nitpicks' 3 points and gives me ideas on how to make it more reliable and less likely to need replaced or completely refactoring in the future.
I think my first time getting code reviewed went well. And one of the things he mentioned was something I didn't know how to do and only took 20 some minutes to implement so I also learned something new from this7 -
Colleague: Hey could you review this diff?
Me: *opens Bitbucket*
Bitbucket: "Upgrade to Symfony 5", 19 files added, 732 modified, 14 removed
Me, 3 mouse scrolls and 20 seconds later: ✅3 -
Best review I received for my app so far. It's a 2FA app, so basically every site where you enable 2FA tells you exactly what to do (scan the QR code)...
8 -
[dec. 21]
lead: thanks for completing all the docs, i'll review them so you can do the revisions next week
[dec. 22]
me: sir, any feedback on the first few? so i can work on them while you review the others
lead: i'll send them EOD
[dec. 26]
was notified by our manager that our lead is on leave til 27. didn't get any email or anything for review points
[dec. 28]
lead: so how's the revisions doing?
me: done. if you can review them again...
almost end of day, haven't heard anything from him yet. -
Manager : what is "looks good" in code review comment??? You have to be more detailed.
Me in next code review : It is not aesthetically pleasing, but it gets the job done. -
I had a performance review with my boss and his boss today.
After they told me what they wanted to, they asked for my feedback. I was very honest with them and didn't only tell them the good stuff but the things I've been disappointed with as well.
Well, last year was mostly a big fat disappointment for me at the company, both on a professional and a personal level, which seemingly took them by surprise and hurt their feelings because they think it is the best place to work at. Even though I tried to make my feedback as constructive as possible, they didn't really seem to understand the problems and kept saying what a good company this is and what amazing opportunities will this year hold.
And they gave me a raise before I could even ask for it.6 -
I had code waiting in review for ten days, blocking other work. On the eleventh day, the final reviewer (who was standing behind me as I wrote it) says "I'm not sure that I agree with the design, here."
I get you, man, I can re-write the algorithm, but I am so not in that context anymore and you've just delayed release of the feature by at least a week. Ugggh.5 -
My project manager just had a project review at a bar because there was no space at the office. There are literally so many people at the office that we're out of chairs. And space. In a few days three more developers are scheduled to arrive. I don't know where we will put them.3
-
Sometimes I like to look at my PR and think "Damn, that's some beautiful code, I can't wait for someone to review it".
Then the review comes and see a bunch of requested changes. =/5 -
When you can't sleep, because you are more worried about your code review...
That's my state right now... -
When someone post a review (3 stars out of 5) where asks to make the app/game free so the developer will get even more downloads, he will give him 5 stars instead of 3, and everyone will be happier...
3 -
Code review, intern style:
Intern: Here is my pull request ...
Colleague: I see a problem with x, y, z. Could cause memory leaks.
Intern: Oh yeah you are correct, i'll fix that in the next one.
Intern: *merged* -
Usually my workplace is pretty chill, but today something rantworthy happened!
During code review, I found this guy had styled each element inside his components using nth-child selectors. For instance, in a card the heading was styled by nth-child(1), the text was styled by nth-child(2) and so on... No use of actual fucking classnames.
When I pointed this out, he told me it was actually the better way of doing things because classnames increase the size of the HTML document!
He also claimed proudly that nth-child() is more efficient in performance (idk - anybody can confirm this?)
I'm the only "css guy" there so nobody could second my views. Posting it here so that I can show this to him tomorrow by demonstrating what opinion other css devs have on this and prove my concerns / convince him to change his code.7 -
I was told by my manager that I should smile more and should always say hi when i meet someone from other department，because that would effect my probation review？！！7
-
Last 4 days, struggling to get ship it from a Dev who is reviewing my code.
The comments have already piled up more than the LOC submitted.
The code review consists of just 2 interfaces and a pojo. Hardly 20 LOC in total, excluding javadocs.
I hope it gets ship it soon.
Wish me luck.2 -
So I wrote a python code and was waiting for +1 on code review and I needed to merge it fast. That shit of a reviewer took his time to finally NOT give a +1 with comment, "if statement has no else part". OF COURSE IT DOESN'T HAVE ELSE PART. I DON'T NEED A ELSE PART. But to give him the benefit of doubt, I'd like to ask devRant community if they believe all ifs should have elses.14
-
Dear team leader, If you tell me „I need to review this merge request before merging”, then make sure you are able to allocate time to do this.
If you need MORE THAN A WEEK to even start, then maybe your delegation skills are nonexistent. -
Just committed a code review change with a heart emoji included, Turns out Crucible does not support this and it broke the code review, Spent the last half an hour trying to change my commit message to fix the review
FML6 -
So there is a 50/50 chance I am getting flamed af tomorrow during code review because of my branching/merging actions on thursday and friday... Merge conflicts... We all love them...3
-
QMS admin: you only finished the code review, you didn't complete it!
Me: opens review clicks complete
QMS: you didn't export the code review comments!
Me: opens code review again. Clicks Export. Attaches *.txt
QMS: you exported the comments in the wrong format, I can't read them
Me: what is the right format?
QMS: SOP document <random alphanumeric> clearly states the format
Me: spends 20 minutes navigating the piece of crap QMS software with no search function folder by folder.
Finds document.
It's 120 pages and 4 years old.
On page 68, I find "template to be implemented"
Reply to QMS, that document doesn't actually give a reference to a template
QMS: Email my line manager "Please teach your staff how to do a code review"3 -
You all talk about your peer review ducks, I present my peer review puppy with my new stickers! I can't help but think he isn't doing his job...
1 -
Do not, I repeat... DO NOT approve a pull request that you cannot adequately review. You're more to blame than the person who wrote the code in the first place when it fails.
-
I'm lucky enough to be able to work with an extremely competent yet down-to-earth and generous senior engineer that it's a pita to write his review abt "area in which he can improve" - the dude already wrote 1/2 the codebase to keep the team running.1
-
Dev sent out a code review request.
I take about an hour, ask questions, make suggestions, general feedback, etc.
Today I noticed none of my questions were answered, developer closed the review, and the code merged into the production branch.
So I email him, asking him why the review was closed and why none of my concerns were addressed before merging to production.
Dev: "No one responded or left feedback, so I thought it was OK to merge up."
Me: "I reviewed and left feedback within the hour you sent the request."
Dev: "Oh yea...you did. Sorry. The code is already in production, but if you still want to leave feedback, create a work item, and I'll take a look."
No you won't.
An example of the code...The dev added an async method to a test harness *console app*. Why? .. check in comment was "Improves performance and enhances the developer experience.."
NO IT DOESN'T!
OK..that's off my chest. No one is getting punched in the face today.6 -
While parsing nodes in a graph.
In terms of readability and variable naming, how wrong (if at all) is to use:
1. broNode (for sibling nodes)
2. papaNode / mamaNode (for parent nodes)
3. babyNode (for child nodes)
I sincerely don't know how to review this PR7 -
Here is a little review, this is more of a personal review, I wanted to make it more professional but it was the first thing I did when I got up after playing on DevRant lol so brain has not yet woken up.
I invite @dfox and @trogus to read it and anyone else who would like to view it.
http://4213.co.uk/reviews/devrant11 -
I had a ticket to enhance the loading of a page.
So instead of doing 40K requests to a MySQL DB in order to generate a tree and display it to to the user on each page visit, the initial query was optimized and moreover, the results are saved in a MongoDB which will then are served to the user on each page visit.
Long story short, after a code review the code got shipped to production and there was a bug which got fixed in a Hotfix shortly afterwards.
I got all the blame for the bug.
I don't deny I have a responsibility for the bug.
Do you guys think the code reviewer also has a shared responsibility for the bug?4 -
"Task took a long time. Should have been more persistent in chasing person."
I honest to god don't give a crap.2 -
Push a PR that fixes 7 bugs...
Feel like a pro :)
Trying to get the 2 required approvals for my PR on a Friday after lunch...
Feels like pulling teeth :( -
to whomever it may concern...
if i wanted to do code review keeping in mind how asshole you have been and made it my personal vendetta, i would not review it at all.
i would let you and your shitty code rot in hell. -
I cant keep this inside anymore I have to rant!
I have a colleague that is an horrendous loose bug-cannon. Every peer-review is like a fight for the products life.
Now I understand - everyone makes bugs me included and it is a huge relief when someone finds them during peer-review. But these aren't the simple kind of bugs. The ones easily made when writing large pieces of code quickly. Typing = instead of == or a misshandling of a terminating character causing weird behaviour. These kinds of bugs rarely pass by a peer-review or are quickly found when a bug report is recieved from testers.
No the bugs my colleague makes are the bugs that completly destroy the logic flow of a whole module. The things that worst case cause crashes. Or are complete disasters trying to figure out what causes them if they are discovered first when the product reaches production!
Ironically he is amazing a peer reviewing other peoples code.
But do you know what the worst thing of all is! Most of the bugs he causes are because he has to "tidy up" and "refactor" every piece of code he touches. The actual bugfix might be a one liner but in the same commit he can still manage to conjure up 3 new bugs. He's like a bug wizard!
*frustrated Aruughhhh noises*9 -
Ticket waiting for code review for days. I have to rename methods.
Tickets goes again to code review. Waiting there again for days. Oops! there is something the code reviewer didn't see before!
Ticket goes to code review again, waiting for days there.
Boss comes to me telling it takes me too long to close tickets. -
How the fuck do you do a performance review?
For me, we need to do self assessments.
Part of it is what I do well, part of it is what i need to improve.
No idea what to put, since I feel like I'm awful at everything lol.10 -
the two code review personality types
review activity:
- dev A: requests code review, sets dev B and dev c (myself) as reviewers
- dev C comments: this review is marked with a complexity > 9000, touches > 20 files and has zero comments... also there's a lot of refactoring going on, making it hard for me to tell what the actual relevant changes are. can you please add more comments to this review?
- dev B (10 mins later): approved review6 -
Last year in my job, I was temporarily assigned to another team to help out in their project as they were short-staffed. It was a massive project and of course there was a lot of code review to be done. But since I was only temporarily assigned, I still have to do code reviews for my base team, this other team I was assigned to, and for some reason, code review for another team that I barely know what their project is about.
There were times where all I was doing was code reviews that took anywhere between a few minutes to upto 3 days. The amount of mistakes and bugs I kept finding was phenomenal. But I think the one thing that got to me was finding the same bugs/mistakes that I kept pointing out to people to stop doing or to fix e.g DB queries inside a loop just to retrieve data.
To this end I still have to deal with the same issue, but thankfully now it's only to one team.1 -
How long do you think code reviews should be? Ours can run from anywhere between 10 minutes to 4 hours4
-
So this might be a very long post , but i am sure most of you can relate to it .
So , the year end . Time of joy and appraisals right?You have slogged your ass off the entire year and are expecting amazing ratings.Then boom , your piece of shit sadist manager starts of his review by saying 'there are worrysome things to discuss' after not saying shit for the entire year . I am pretty new to corporate , in fact 1 year old , still managed to handle devops for a team of 130+ , majority of whom have no work apart from playing a blame game and indulging in cheap politics. I mean , bro , I am literally your son's age , i dont see the point in playing this cheap shit with me.On top of that this sadist and borderline piece of shit manager has the audacity to say that I did not raise any blockers , while I have CCed him in every fucking mail possible.How big of an a****** can you be bro?
I counter his points for 40 45 mins straight ,leaving him stuck without words for solid 10 to 15 seconds many times during the 'review meet'. This guy is in the same place working on the same shit code , which 90% of this community can't even think of. Every thing is bloody manual and apparently ' I should have tried to streamline the entire f**** process' . Cool bro , why not open a startup while I am at it ?
Then this piece of poop gives me a rating which is just above the inconsistent performer bracket :) .
I just dont get the points what do these people get by giving shit ratings and not even having valid points to back up their fuck all arguments.This guy , throughout the duration of the call did not say 1 (bloody 1 ) good thing about my efforts. Past context is majority of the smart people who were literally running their pods single handedly , were under him and were fed up with not getting hikes and appraisals.Apart from me ,everyone resigned and left with hikes as high as 50% (LOL right).
But I have a year of experience and its really difficult to perform well in 4 rounds of bs compititive coding rounds, after which I get the generic ' oh you did well bro but we are moving on with other candidates' (FFS) .
I pray that even my worst enemies don't get such managers and I hope he rots in hell.
Amen and sorry for the cussing :) -
What is the best way to do a code review for a colleague's code, without coming out as a complete ass?16
-
They tell me to only review security in the security reviews I'm doing (and if I bring to attention that they're implementing a weak encryption so even though they're not using it at the moment it might cause issues so be careful with that they say to only review security 😵) and then I see this mssql in a where:
AND ISNULL(field, 0) IS NULL
And I think wtf, should I report that? I did and it's a bug and they're thanking me now....
God dammit it's hard to "review security" here...3 -
Definition of code reviews in our company:
"Part of work that requires you to scroll to the bottom of the page and click accept button. Looking the changes is optional."4 -
Am going through documents and found an old review on a paper I wrote in semester 1. Now, I wouldn't say my paper was either good or bad. There was not enough guidance provided in the unit and I was unfamiliar to the scientific asshole community so I tried my best.
But in particular, fuck reviewer 2. He doesn't understand basics in English and he has the audacity to make judgement. Like, I am not "misspelling" you moronic asshole who doesn't even know the difference between American and English spelling.
He wrote three fucking pages. This moron wrote about half the length of my paper about why my paper is shit. I hope he chokes on shit.
He goes on to why every figure was useless or wrong; How no section is related to another; How everything is either not explained enough, or explained too much. The audacity is what he suffers from throughout the review.
In conclusion, and given the contrast between reviewer 1 and 2, I'd recommend reviewer 2 goes on to fuck himself. Moronic bastard.
It's a pity that I know this will happen again in future. God this makes me so angry. Gah.5 -
Work rant :
I once had a code review and remembered I forgot to comment my code and said sorry I forgot to comment it out.
The reply I got?
Don't worry, here we say your code should be readable enough and no comments are required.
Im still amazed, like... Even if the code is readable, fuck this I need a tl;Dr comment for the long ass fucking code... What the fuck5 -
Hi, guys, about a month ago i created a covid 19 live tracking website for my portfolio. But today remember i could ask for review in devRant about the site. So i hope you give me any upgrade suggestion for the website.Anything like ui/ux or new content or faults etc
website link :
https://covid19trackermj.herokuapp.com/...11 -
I just watched "Venom" in 3D.
That was awesome. I also loved the "Parasite" manga and anime reference. Plus, they made the labours and weapons of the aliens look like those from the game "Prototype" 1 and 2.
Would really watch the future movies of Venom and recommend everyone who did not watch this movie to watch it. It is a masterpiece.4 -
My best code review was when my merge request was accepted in less than a minute after creation. It was simple but I expected more time on review and accept action.
-
Why comment on the same thing during code review??
I submitted a PR and had to make a design choice that propagated throughout the module i was working on.
During code review, my coworker commented on every...single...line that this change effected asking "why are we doing x here?" instead of just creating ONE SINGLE THREAD with this question for discussion. There were at least 10 review comments on github from their one review that said "why X?"
Is this normal? Ive only had a few programming jobs and this is the first time this has happened to me.
personally, when someone makes a choice like that, i just make a comment and save the rest of the review until that is addressed.5 -
Boss(non-technical) complains we are behind the schedule he set without consulting the tech team, the complains we don't all(including BAs) don't do code review. CHOOSE!
*Note: I am not bashing code review*2 -
Customer has design review for big project I’m working on, have to sit with someone who isn’t a developer and explain my code.
Cunts, cunts, cunts.
If you don’t understand or know about code maybe you shouldn’t be a code reviewer. -
I'm currently at a company where we have "performance reviews" every 2 weeks, and based on the outcome we get a percentage which then is used to calculate a performance bonus.
This is simply my manager (also a developer) who has his Excel spreadsheet, looking at tasks I did over the course of the past 2 weeks and almost nitpicking to find some fault. There is no code review or software demo to see what's been done either... I was there for the first 3 months and I don't think anyone had even open my code!
And when confronted, I get told that "You should also somehow be financially liable for the goings-on in the business", along with a 2 hour meeting to support that.
This is NOT how you motivate developers!
Apologies for the long rant...
</rant>7 -
Code review moment that I hate
Me: This is a bad practice. You shouldn't do this
Developer: But it works
*Showed articles and examples why it's bad*
Developer: I see. But it works. Why should I change it?2 -
Do people just see reviews (if any kind of work) as an admin task? Just a box to tick on the way to production?
Seems like it is here. -
Today a senior developer and a colleague started looking into my code reviews and started commenting best practices that were never used in the team.
Got my chance back at the senior developer's code when he raised a code review, which had none of the best practices.
Gave back a good set of review comments to him :D
Karma is a boomerang :)2 -
Send 500 loc for review, get "looks good!"
Send 10 loc for review, get 500 words with questions (about the reviewer's preferences).
Sigh. -
I work at a small company (less than 10 developers). We tried to do code review but all of our projects are "work for hire" for our clients and we always have deadlines. Code review step always had the least priority and whenever the deadline gets closer, we would stop doing code review all together.
Finally we are starting our own projects and we are planning on hiring more developers and interns. I think code review will have a higher priority now.1 -
When slack is down for 3 hours, but ur boss facetimes u and ses we need to review CVS and then u need to stop playing euro truck simulator and start working 🙃.4
-
I know many teachers are very emotional about technology as I've heard here.
My English teacher got next to me to ask what text editor I was using for writing a movie review. I was using VSCode and writing Markdown. He was like cool, smart. Didn't get it, but agreed.
I didn't expect that. -
Feeling like shit, tired, stressed and then going into a performance review where aparently im far exceeding what i need to do. Makes me wonder why i need to feel like this, i dont really feel excited although there was positive news.. I think i need sleep1
-
I'm doing a code review on a huge feature, basically touching every part of our authorization logic, and man... It's like my colleague writes his code to be as hard to read as possible. He's 60+ and you'd think he'd have learned how to write good and clear code, but nope. "Let's make it cool cool and I look like I'm a genius. And if I can spend 3 keystrokes less on a function I'm happy". Fuck me.
-
Having a meeting to decide, when to have other meetings...
Scrum, scrum of scrums, workstream, planning, pm ,design review, architecture review, Sprint review on and on....on and on on...why can't i simply code:(4 -
Genuine question, what was the most comments you've left in a single code review?
Just reviewed pull request submitted by a developer working for a contractor company and needed to leave 70 comments. Seventy.
Opened LinkedIn and saw a post from that same developer saying he left the contracting company an hour ago. I still can't believe it.12 -
What's the longest code review meeting you've ever had? We're about 3 hours into this code review so far, and it doesn't sound like we're going to be done anytime soon3
-
Yay my first day back and I'm 1 hour and 15 minutes late because the main road I take into work was a parking lot. And then I have to go directly into the world's longest meeting. And I have a peer review to do so I guess no dev soon for me today.
-
What I absolutely hate the most of my workflow is to hand over my code for review to other developers.
I know it is important to prevent errors and to get feedback from them to improve, but I'm far from being self-confident and I'm afraid of showing others my work, regardless of the fact that nobody said anything mean about my work.3 -
Me on code review : You should extract the logic into a separate method for better readability. Colleague completely ignores it. What should I do?6
-
Oh my fucking god, we're doing SCRUM, why does every task get stuck in review limbo and take a sprint and a half minimum because of it.
-
This is why code reviews are important.
Instead of loading a relevant dataset from the database once, the developer was querying the database for every field, every time the method interacted with it.
What should have been one call for 200k records ended up as 50+ calls for 200k records for every one of 300+ users.
The whole production application server was locked.2 -
==============
Getting Feedback Rant!
=============
When "this is simpler" feedback results in a function of 500 lines of code.
When I get "don't do X" in the feedback. Thank you very much. What do you want me to do instead?
Unclear feedback.
When the feedback giver changes his mind after I applied the changes!
When applying the feedback introduces a bug.
Simply opinionated feedback that is not enforced by any tool or backed up by any facts.
Please find something better to do in life.
Unactionable feedback.
"Consider X"
I will not consider thank you very much.
"Verify this works"
Duh..
When the feedback giver knows something that you don't.
I know this is a legit case.. still annoying.
"I disagree with the feature"
Go argue with the PM, not relevant to me, thanks!
=====================
GIVING FEEDBACK RANT
=====================
I rewrote the system. Please review it.
No need to review, just approve.
I will change this as part of the next ticket.
I would like to keep it the way it is.
lazy ass..
You can't test this.
It's impossible to test this.
No need to test this.
There's no point to test this.
I'll test this on production.
Not sure why this is working..
Please document this..
Because documentation is like a thing, you know.
Oh, this code is not related to this PR, I just don't want to open a new branch for such a small change. ignore it.
Ignore this.
This will be meaningful in my next change. -
What's that? You committed the tmp/dist/cache field for something only YOU run locally and asked me to review it. Just GET OUT.1
-
> be me
> complete tickets overnight
> submit for review
> takes 2 days to review
> still no word
> more tickets raised with incomplete information
> ???
> profit5 -
Best code review experience was when I was mentor in a bootcamp and I had to review code from scholars, they were surprised by how their code could be written in less lines.
-
I'm slowly realizing how much goofy code I put in my branch and overlooked. This code review is going to be interesting...
Some examples:
import plots as lel
<h4 id="title">Crunchatize Me, Captain! </h4>
go.Scattergeo(name="cheese", ...)
webster = { ... }
The commit messages are even worse.
- 'horizontalize' link list
- very messily hack in <feature>
- partially refactor some of the awful code from previous
- Remove one annoying space
- make background color less annoying
- remove seemingly useless property
- minor fix
- Apparently it's possible to center a DIV. Who knew?
- Made some cool bar graphs
And then there's just a bunch of reverts.2 -
We only recently started and we can really see the benefits of code review.
It motivates you to follow the standards, writing good quality code and using variable/function names that makes sense. Especially that you know someone is going to read through it.1 -
It is ok to fail and commit mistakes, that's part of the game, specially for beginner devs. Just avoid failing alone, the most you can!
I mean:
- Ask people to review your code before pushing to the source repository.
- If you are not sure how to do, ask.
- Never work in production environments without supervision. Pair with someone.
- Have a desk mate for rubberducking (https://en.wikipedia.org/wiki/...) and blame it in case you need -
Demo driven development.
Fucking nightmare.
Did a simple search for TODO Statements in the code and almost fucking spilt my coffee.
And the best part, they will demo most of this in Sprint review as done.. WTF.
Done means "Ready to Release" not "Ready to Demo".2 -
What do you guys think of code review? It was supposed to find potential mistakes in your code base, and share your knowledge with your co-workers, right?
In fact I have very bad experiences with code review, not just with 1 company, but quite a few. Code review process always comes to something like this:
Reviewer: Hey, I don't like your solution A because of disadvantages A1. You should implement solution B, because of advantage B1 blah blah...
Me: Yes, it's true that solution B provides advantage B1, but at the same time introduces much more complexity to the code base than necessary, and has disadvantage B2. I am aware that solution A has disadvantage A1 but it is justifiable and easier to overcome than B2 imo. In fact, solution A also provides advantage A2 that you might not know...
Reviewer: No, you HAVE TO implement B because of advantage B1 blah blah *repeating why B1 is awesome again*
I feel like it's just people trying to shove their preferences down my throat. Either code review is useless, or the companies I work for do something very very wrong in code review. Anyway, it's really discouraging me fron participating in team discussions.5 -
Fucking hypocrite, tell me to create a review for fucking version changes, they create a review of significant build system changes, don't add all their changes to the review and merge it while it's being reviewed... And I'm super unhappy with their changes...
-
Code got submitted for review... Syntax error.
Like wtf, your IDE even tells you about syntax errors... not to mention the failing build 😤 -
A former team lead decided the team should review any open PR before proceeding with their own tasks after their breaks. Any open PR also meant reviewing refinements in an ongoing discussion. Several times, we wasted time for review, coding, and discussing when the second reviewer asked to revert the changes introduced according to the requests of the first reviewer.
Now as a freelancer, in smaller projects, I sometimes have no coworkers to review my code. So, apart from testing, I try to pay more attention to linters, static code analysis and automated coding assistance. I have stylelint, eslint, SonarLint, and possibly some more IDE inspections. For the infamous popular blogging software, I also have a so-called PHP code sniffer that checks all PHP and JavaScript code for compliance with the WordPress coding styles, so finally, I got the team experience back: SonarLint suggests removing unnecessary spaces and reformating my code, which in turn makes PHPCS complain that the code violates the legacy code style. -
What's the best way to ask my IT manager for a first year review? What's the best way to approach it from a junior position where I feel I'm being underpaid and overworked?3
-
Picked up an issue to contribute to OSS for a community version of a major enterprise software. Did the changes, submitted a pull request. Someone reviewed it, asked for some changes, which i did and pushed the changes.
Then after some discussion with the guys working there, we thought of making some changes to the UI. Step in the company UI guy, he makes some changes, i merge his branch into mine and submit a new pull request.
Now, a new guy comes in to review the code, who has a problem with every change THEIR UI Guy did, and negates everything the first reviewer said, and asks me to do the changes, and boy was I pissed!!
But I did the changes, updated the PR, then the first reviewer comes in again, and suggests some more changes, most of them are for the code, THEIR UI Guydid!! Fucking psychopaths!! Never had i seen such paranoid people in my life!! Educate your fucking team first!!
I one again started with the changes but left mid way!! Now, even if i want to, will not update the PR!! FUCK YOU!!3 -
How do i handle code review as a junior developer?
I understand its need and I don't want to skip it.
But I feel under confident after code review when my mistakes are pointed out. They always seem so trivial and wonder how did I even miss them. How should I handle such situations? And how do I improve from here?6 -
Today I read a book and it talks about giving feedback on others; as a developer we tend to give feedback and review others code almost everyday. When I write the code I always put a lot of effort on making it look at prefect but I found I am having trouble on receiving others criticising and comments being judgemental. Instead if we make it as a "draft" rather than "final", that will make you becoming more open towards others opinion. I find this is quite true and I hope this could benefit developers who have similar attitude :)2
-
For you Mechanical Keyboard peeps out there, I just wrote a review about my SliceMK (Erogodox clone), Model M and RK84:
https://battlepenguin.com/tech/...
4 -
Writing my first code review. Even though it really is a nice review and I'm happy with the solution code, I still somehow feel like an asshole for each critique I make. Maybe it's unavoidable with code reviews / pull requests?3
-
Currently there are 1273 plugins awaiting review after submission to WordPress plugin server. Nearly as much as the 1345 open "type: bug" issues in WordPress/gutenberg on GitHub. Reminds me of "Suggested edit queue is full" on StackOverflow. Either too many people contribute to open source, or too little seniors willing and able to review, or our workflows don't work well enough. But good to see that there is still stuff going on in communities and not everyone just playing around with AI tools or uploading social media content all the time.1
-
What is wrong with these people!!!
Last minute changes are pain in the ass... the design team review gives a go ahead but then pm team doesnt agree and and you have to get the changes suggested done in a day??!!!
In half a day you have to get ux review, peer review, module owner review, architect review, pm review and then merge publish bump and test in ci?!!end of sprint is today...
Ugh!!!every sprint!!every fuckin sprint!!! -
so I've made a coolors palette, and I think it looks good. What do you guys think?
https://coolors.co/u/fbarda4 -
Not before long, I guess we may have to put up with bots during code review...😂
Meet the Bots That Review and Write Snippets of Facebook's Code
https://spectrum.ieee.org/tech-talk... -
So when writing golang code, you can put alias into the imported library
And one of interns in my office include include our company's library called "helper/session", and alias it with 'hSession'
Now all the code which use that library has to look like "hSession.ErrUnexpected", "hSession.NewSession"
Well, i think i've played too much VN and anime, but still i'm having a good laugh when doing the code review -
Doing a code review (Of code written by another person...different code styles and weird methods can really get you a gray hair or two :D)2
-
Men fo real! I dont rant so much because I think its a negative attitude but let me do it anyway! Listen. My boss boss told me to create a dynamic drop which I did. A backend request then display it on the frontend which is easy, then on code review he ask why do we need this error handling. Bruh as soon as I heard that question, I got covid. Bitch we do need that error handling because if theres error on requests it will set to default options, but I didn’t say anything tho. I just ask what will happen if there’s an error?, he said I don’t think a simple request will respond error if you did it right. Then I agreed and remove the code. Hot damn! Mind you guys. When they started the app there are no test code. 0, nada, nothing inside the spec folder.7
-
I had been working to make API call Asynchronous..
And now complexity is too High..
Yet i am happy that Code working as expected..! -
We don't talk enough about type 2 error! So many papers everywhere are just pure trash because they don't account for it, and people are so fucking oblivious about it, they don't even catch the obvious ones. Even researchers and publications which are supposed to properly review their articles simply fail to ask the obvious "Did you measure the segment which doesn't fit either of your variables?"7
-
I displayed "score: 0" on the dashboard and on the review list, tester noted it as a bug stating; it should have been "score: 0.0" and not "score: 0" because the score is precision based.
You can say this is a half cup full and half cup empty scenario but I will call this silly cup full and brain cup empty!3 -
It takes days to get a review. 3rd notice unanswered. So today it will be merged without review of 5 MRs. We’ll see what breaks in prod anyways.4
-
This is why i hate android ... look at this REVIEW i received today:
"PLZ WORK ON IT ITS JOR WORK ON FB MESSENGER BEFORE DAYS PLEASE DO SMTHNG" what am i supposed to understand xD, i tried it on my device and my friends one its working like a charm :(3 -
SeniorDev(in code review): Yeah, I know this is wrong but I will look into it later
Me: Can you please mention the ticket you have created to look into it later
[JuniorDev gives me a high five for sticking to our coding principles. No sweeping under the rug! Felt awesome.] -
Bossman called me up the other day, asked if I had looked at courses and told me I should think about signing up in September.
Thing is, I don't have a degree or anything beyond a high school diploma, since I'm self taught and got hired because of my ability to learn fast and my portfolio, and I told them I'd consider looking at a two year program.
But I don't want to have to be doing coursework after work, and besides, if I do a course, I want to do so because I wanted it... Sad thing is, yearly review is coming up in a month and I worry my salary is gonna stay where it started... Which is not great :S
Any thoughts?5 -
Afternoon spend arguing about small cosmetic changes in code-review effectivelly delaying the release. Feel so productive and understand why everything takes us so long. But looking forward to next week so time sunked in code-review will be larger than the development time.3
-
If some older employee writes the same code, nobody bats an eye. If a newer employee (with less than 2 years in the company) writes the exact same line, everybody loses their minds (in PR review)...
Not that I give too many fucks generally, but sometimes this partiality is annoying AF.
This causes: https://devrant.com/rants/2263742/...1 -
Code Review is one fucking awesome stunt.
- Take a long sommersault flip.
- Land on your face or your ass, it doesn't matter.
TBH, lot of learning insights during the review. -
Recently I've finally finished my first game in Unity3D <3 But I'm self-taught and it's probably not really well-made. I'd love to show code to someone with real experience but I don't have any friends in game dev -.-
Does anyone know where I could get some kind of code review (for free would be great, since I won't earn a penny from this game)?
Shameless plug for anyone interested:
https://play.google.com/store/apps/...1 -
Sometimes I hate StackOverflow's review because I tend to comment and the post turns out to be 5yo top question with inf. amount of comments.
And there I come, the captain obvious, bumping an old thread because the review told you it's 2hours old or something. -
People that approve pull requests without looking at them!
No tests or so bad they would do more use by not existing, typos, the code follows none of the design practices and the code obviously will not compile and thereby breaks builds in trunk for everyone.
Because of course they only asked one person to review it and then merged it immediately. -
It's kinda hard if you're a beginner and don't know if you're doing things with good practice...
I would really appreciate if someone could review my code and tell me if I'm on the right track: https://github.com/Dollique/...
For Info: I'm doing this all by myself for a learning purpose and I know I could easily use a finished framework :)
Thanks!1 -
Anyone free and willing to help me with a react code review?
I’m stuck somewhere and not sure where i went wrong12 -
How does your organisation and team balance PR comments demanding changes and dev time?
Here, while fixing PR comments we sometimes end up wasting as much time as we took in actually developing the feature... As a result, almost every major user story overshoots the estimation and almost every sprint gets delayed.
Yes, to each his own; but talking in general, why do you think this time wasting happens?
Do you think that happens because some of us are not as experienced as the others, the existing code not being up to the mark giving a bad example, or just a skewed review process?2 -
I'm doing a code review and, it's not unheard of to have lowercase SQL im our codebase even though most of it is uppercase. For this reason I decided to let the lowercase SQL slide even though it makes me cringe so much... That is, until I came to one procedure that was uppercase and in this revision it is lowercase :O I want to die a gruesome way which would be very nice compared to this :O
-
Just found this article sharing the opinion of a dev on software project fail with points I saw mentioned here on devRant, but also on other dev-related places. What do you think about it ?
https://codeproject.com/Articles/...1 -
When I get a code review by my self-proclaimed expert colleague suggesting a change that ends up breaking the feature, I just implement that spaghetti code and let the testers know I'm not to blame.
-
Sometimes I don't do a proper review because I don't want to seem very nitpicking. However, now I have to maintain the code that was merged and it has some stuff which is not correct. Now I have to fix it.1
-
Ugh posting a review on Play Store is an awful experience. The text editor doesn't let you copy or paste and you can't even see your full review once you've posted the damn thing. Why Google 😡
-
Today I submitted to code review the first iteration of a microservice done with Ramda and flow by request of my collegues. This is the first time they look at anything similar to functional code or typed js, and only one of them took the time to actually do a review.
I really like having my code reviewed and reviewing others', but please don't pester me to make a PR for a microservice you'll never look only to bail off as soon as you see something new that scares you. Buckle up and learn new stuff! -
Is this a justified code review comment or a bully?
Code reviews are weakness of this industry which has the potential to attract bullies. Abuse of the comment box in a pull request and bombarding the employee with hundreds of comments can cause stress, frustration, burnout and finally resignation and costs of fulfillment for the organization. While companies should find and stop bullying in the work place, what kind of code review comment is considered a bully and why? Any of below traits can mean you are dealing with a bully:
1. Claims the code needs to be changed but doesn't say how. So no matter how many times you change your code, he can repeat the same comment: "Your code is still bad due to blah blah and it needs to be changed".
2. Provides how the code should be changed, but the change doesn't add up to quality, security, performance, readability, etc. i.e. "Why did you use a for loop here? Use a while loop instead". Or "Why did you write it using three classes A, B and C? Instead write it using 4 classes D, E, F and G which does blah blah". In the later case, not following the review comment, you won't get approval. Following the comment means you need to rewrite your whole code. After which, you might again receive more comments to change other parts of your code!
3. Claims the requested change is due to standards but claimed standard does exist anywhere. Internet, company wiki, university course books, anywhere. In more severe cases of psychopathy, the bullying person refers you to a link which hours later turned out to be written by himself! Have fun describing what has happened to your manager or team leader... .
4. Asks the code to be changed in a way that supposedly is closer to standard or of better quality, security, performance, etc. But the proposed way will not work and is the main reason you didn't do that in the first place. So you start arguing forever in the comment box over why his method won't work!
If you cannot see any of the above traits, then keep calm, take a breath, fix your code. Otherwise you might be victim of a bully.3 -
I haven't been playing as many games lately. After 36 hours over the course of 8 weeks, I finally got through Stellar Blade. Not the greatest and a rough start, but overall I give it a 73%. Read my (spoiler free) review:
https://battlepenguin.com/gaming/...1 -
I wonder if we will have a sprint review meeting for 2016. You know to prevent the shit storm that happened to continue ...
Top Tags
Weekly Rant
View